fix(receipt): detect subtotal/total when OCR splits label and amount - #46
Merged
Conversation
Promote to production: Image OCR + Receipt Scanner
PP-OCR emits a label and its amount as separate boxes on the same visual row, so 'Subtotal'/'$100.00' never matched (keyword and amount were on different lines) — subtotal/total/tax came back empty. Group detections into rows by vertical overlap first, then run the finders. Fixes both the OCR 'Parse as receipt' mode and the Receipt Scanner tool. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | c25201e | Jul 30 2026, 11:30 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: on real receipts, subtotal/total/tax fields came back empty even when the raw text clearly showed
Subtotal $100.00.Cause: PP-OCR detects the label and the amount as two separate boxes on the same row. The parser required the keyword and the amount on the same
line, soSubtotal(no number) and$100.00(no keyword) each failed.Fix:
groupRows()merges same-row detections (by vertical overlap) into one line before the finders run — mirroring how the display text is already assembled. Fixes both the OCR Parse as receipt mode and the Receipt Scanner tool (sharedparseReceipt).Reproduced with a split-segment test; 470 tests pass, lint clean, build green.