chore(desktop): clean up all Rust compiler warnings (12 → 0) - #5
Merged
Conversation
Down from 12 warnings to 0: - remove unnecessary parens in capture_screen_fast - drop unused `std::path::PathBuf` import in recording.rs - remove genuinely-dead overlay::Rectangle struct (+ its serde import) - #[allow(dead_code)] on frontend-contract fields not yet read in Rust (CaptureOptions/RecordOptions bitrate + audio flags) and on RecordingState snapshot fields and the reference capture_screen_internal helper - declare cfg(cargo-clippy) via [lints.rust] check-cfg so the objc msg_send! macro no longer trips unexpected_cfgs Build is warning-clean; audio unit tests still pass. No behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013dqouzFP8vy9jaKhTDFj5H
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Zero-warning Rust build for the desktop app. Independent of the in-flight capture PRs (#3, #4) — touches only pre-existing dead code and lint config.
Changes
capture_screen_fast.std::path::PathBufimport.overlay::Rectanglestruct (+ its serde import).#[allow(dead_code)]on frontend-contract fields not yet read in Rust (bitrate + audio flags),RecordingStatesnapshot fields, and the referencecapture_screen_internalhelper.cfg(cargo-clippy)via[lints.rust]check-cfg so theobjcmsg_send!macro stops trippingunexpected_cfgs.Testing
cargo build→ 0 warnings; audio unit tests pass. No behavior change.🤖 Generated with Claude Code