fix(camera): switch-camera error + duplicate result buttons - #51
Merged
Conversation
Promote to production: Camera Capture
1. useCamera released the old stream only AFTER acquiring the new one, so switching threw NotReadableError (device busy) → 'Could not start the camera', and the error UI hid the switch button (stuck). Now release before re-opening, and if a switch fails, fall back to the previous camera so the user is never stranded. 2. CameraTool rendered its own Copy/Edit-in-Annotator buttons on top of the ones ImageResult already provides — removed the duplicates (keep Retake). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
goodwebtools | f258b4e | Jul 31 2026, 03:53 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two camera bugs from user testing:
useCamerarequested the new stream before releasing the old one; on single-stream devices that throwsNotReadableError. Now it releases the current camera first, and if the switch fails it falls back to the previous camera so you're never stranded on the error screen.ImageResultalready renders those viaResultActions; removedCameraTool's redundant copies.481 tests pass (+2 for switch recovery/release), lint clean, build green.