fix(file-transfer): survive file-picker backgrounding (mobile reconnect) - #68
Merged
Merged
Conversation
…e tab Reported: opening the native file dialog on mobile disconnects the peer and it can't reconnect. On a phone the file picker backgrounds the browser tab, which drops the WebRTC connection to 'disconnected' — and the hook treated that as a terminal error with no recovery. Fixes: - Treat ICE 'disconnected' as transient: a 5s grace period to self-heal, then re-establish through signaling (reconnect + renegotiate) instead of erroring. 'failed' re-establishes immediately. Manual mode (no server) still errors. - Re-establishment reconnects signaling on demand (signaling is closed once P2P is up to avoid churn) and re-negotiates a fresh peer; robust to either side reconnecting first. - Cap consecutive re-establish attempts (4) → clear 'add a TURN server' error instead of an infinite reconnect loop on unconnectable networks. - Let the sender pick the file WHILE waiting for the peer (queueFile); it auto-sends the moment the channel opens — sidesteps the picker-backgrounding race entirely for the common flow. DO relay re-verified via local wrangler dev. 539 tests · lint clean · build green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported: on mobile, opening the file dialog to select a file disconnects the peer and it can't reconnect.
Cause: the native file picker backgrounds the browser tab → WebRTC goes
disconnected→ the hook treated that as a terminal error with no recovery.Fixes:
disconnectedis now transient: 5s grace to self-heal, then re-establish via signaling (reconnect + renegotiate).failedre-establishes immediately. Manual mode still errors (no server).queueFile) — it auto-sends when the channel opens, sidestepping the picker-backgrounding race for the common flow.DO relay re-verified via local wrangler dev. 539 tests · lint clean · build green.
🤖 Generated with Claude Code