🎨 improve AddLinkDialog and NavigationBar with enhanced interaction f…#36
Merged
Conversation
…eedback and layout adjustments
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the AddLinkDialog and NavigationBar components by improving interaction feedback and layout structure. The changes separate interaction sources for independent visual feedback and restructure padding to be element-specific rather than container-level.
Key Changes
- Modified
AddLinkDialogto centralize thedismiss()call withinonConfirm()function - Refactored
NavigationBarto use separate interaction sources for the tab icon and add button, enabling independent pressed state tracking - Restructured NavigationBar layout by moving padding from the outer Box to individual interactive elements
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| AddLinkDialog.kt | Moved dismiss() call from keyboard action and button click handlers to inside onConfirm() function |
| InboxListScreen.kt | Split single interaction source into two separate sources (tabInteractionSource and addInteractionSource), wrapped Images in Boxes with individual padding, and removed container-level padding |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DGuang21
previously approved these changes
Nov 28, 2025
…xListScreen.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DGuang21
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eedback and layout adjustments