feat: configure Bluetooth visibility#516
Open
duhow wants to merge 4 commits into
Open
Conversation
duhow
marked this pull request as ready for review
November 13, 2025 15:41
Author
|
@philippe44 any chance to review this? 🙇🏻 |
mestrode
approved these changes
Feb 12, 2026
philippe44
reviewed
Feb 16, 2026
| * @brief Set Bluetooth discoverable mode based on settings | ||
| */ | ||
| void bt_set_discoverable(void); | ||
|
|
Collaborator
There was a problem hiding this comment.
It seems that only bt_app_sink needs to see that function, no ? Then it should be static to that file
Owner
|
We are in the process of upgrading to esp-idf v5.5. I will keep this PR open, but it will likely get closed and implemented as a feature of the upcoming release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454