Add cpShapeIsPoly, cpShapeIsSegment, cpShapeIsCircle functions#223
Open
mcclure wants to merge 1 commit intoslembcke:masterfrom
Open
Add cpShapeIsPoly, cpShapeIsSegment, cpShapeIsCircle functions#223mcclure wants to merge 1 commit intoslembcke:masterfrom
mcclure wants to merge 1 commit intoslembcke:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #219.
Imagine you are writing a cpShapeEach callback to draw a scene which contains both circle and poly shapes. At the moment, there is no way to determine whether any one shape addressed by the callback is a circle, a poly, or something else. However telling circles and polys apart is necessary because functions like cpPolyShapeGetCount() assert-crash when called on the wrong kind of shape.
This patch adds three new functions
cpShapeIsPoly,cpShapeIsSegment,cpShapeIsCirclethat do the expected thing. I am indifferent to whether this is the best naming for these functions.I tested this by doing a successful build and calling cpShapeIsPoly in live code (although my tests were in a feature branch based on older Chipmunk.) I did not attempt to modify any documentation.