Reset velocity and constraint jAcc when body type changes to DYNAMIC#239
Open
viblo wants to merge 1 commit intoslembcke:masterfrom
Open
Reset velocity and constraint jAcc when body type changes to DYNAMIC#239viblo wants to merge 1 commit intoslembcke:masterfrom
viblo wants to merge 1 commit intoslembcke:masterfrom
Conversation
(cherry picked from commit e13d977f723ae3d2b743cb278eae25e107d71e35) (cherry picked from commit f23cbc2)
Owner
|
Another minor issue to point out with this is that if you are adding constraints between non-dynamic bodies, they don't do anything except consume CPU time generating unused NaNs. The client code already needs to be adding and tracking a list of constraints somewhere, all they need to do to fix this is to remove the constraints when making the body static. I don't doubt that this patch works, but I think I need some more convincing that adding this workaround is worth it as, again this is the first time in 15 years I've heard of someone wanting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fix for #238