Fix INFINITY checks for fast-math compatibility#262
Open
tguerin wants to merge 1 commit intoslembcke:masterfrom
Open
Fix INFINITY checks for fast-math compatibility#262tguerin wants to merge 1 commit intoslembcke:masterfrom
tguerin wants to merge 1 commit intoslembcke:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The sleeping mechanism froze when enabled because
-ffast-math(enabled by default in Release builds) optimizes away directINFINITYcomparisons, causing(sleepTimeThreshold != INFINITY)to always evaluate incorrectly.Solution:
Replaced all
INFINITYcomparisons withisfinite()/isinf()across the codebase:cpSpaceComponent.c: Fixed sleep check incpSpaceProcessComponentscpBody.c: Fixed mass and idle time checkscpSpaceStep.c: Fixed collision filteringcpBB.h: Fixed segment intersection checkChipmunkDemo.c: Fixed kinetic energy and point query checksFixes #260