Replace Imgur with ImgBB for album cover uploads#259
Open
MsNecromancer wants to merge 3 commits intosll552:masterfrom
Open
Replace Imgur with ImgBB for album cover uploads#259MsNecromancer wants to merge 3 commits intosll552:masterfrom
MsNecromancer wants to merge 3 commits intosll552:masterfrom
Conversation
Swapped out the Imgur uploader for ImgBB. Works the same way but actually works. Remove ImgurClient/ folder and ImgurUploader.cs Add ImgBBUploader.cs using plain HttpClient Remove RestSharp dependency (no longer needed) Rename ImgurClientId setting to ImgBBApiKey Users need a free API key from https://api.imgbb.com
Updated album cover upload feature to use ImgBB instead of Imgur, and added note about requiring a free API key.
Removed duplicate Tools Menu image and related text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Imgur's API has been having issues lately and album cover uploads have been unreliable for a lot of users. This replaces the Imgur backend with ImgBB which works the same way but actually works.
Changes
Notes for users
Users will need a free API key from https://api.imgbb.com to use album cover uploads. It takes about a minute to set up.
Testing
Tested on MusicBee (v3.6.9403) running under Wine (v11.4) on Arch Linux (rolling) with Discord IPC bridge (v0.0.3.0.g86fcbdd-1) as a go between for Discord (v1:0.0.129-1).