fix: set permissionMode when --yolo flag is used#136
Open
AndyWendt wants to merge 1 commit intoslopus:mainfrom
Open
fix: set permissionMode when --yolo flag is used#136AndyWendt wants to merge 1 commit intoslopus:mainfrom
AndyWendt wants to merge 1 commit intoslopus:mainfrom
Conversation
Author
|
I branched off of I tested on mac / android |
The --yolo flag only passed --dangerously-skip-permissions to Claude CLI but did not set options.permissionMode internally. This caused the PermissionHandler to stay in "default" mode for remote/mobile sessions, resulting in permission prompts even when yolo mode was selected. Additionally, when the CLI is started with --yolo, messages from the mobile app with permissionMode: "default" would override the CLI's setting. Now the CLI's explicit mode is preserved unless the mobile explicitly chooses a different mode. Fixes slopus/happy#206 Co-Authored-By: Claude <noreply@anthropic.com>
ad9192d to
40ff9ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #206 - 'yolo' mode not sticking in happy app
This PR contains two related fixes:
Fix 1: Set
options.permissionModewhen--yoloflag is usedThe
--yoloflag only passed--dangerously-skip-permissionsto Claude CLI but did not setoptions.permissionModeinternally. This caused thePermissionHandlerto stay in "default" mode.Fix 2: Preserve CLI permission mode when mobile sends "default"
When the CLI is started with
--yolo, messages from the mobile app withpermissionMode: "default"would override the CLI's setting. Now the CLI's explicit mode is preserved unless the mobile explicitly chooses a different mode.Test Plan
happy --yoloNotes
Related