security(docker): run containers as non-root user#545
Open
HirokiKobayashi-R wants to merge 1 commit intoslopus:mainfrom
Open
security(docker): run containers as non-root user#545HirokiKobayashi-R wants to merge 1 commit intoslopus:mainfrom
HirokiKobayashi-R wants to merge 1 commit intoslopus:mainfrom
Conversation
- Dockerfile.server: add USER node directive and set file ownership via --chown=node:node - Dockerfile.webapp: switch from nginx:alpine to nginxinc/nginx-unprivileged:alpine, listen on 8080
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dockerfile.server: addUSER nodedirective with--chown=node:nodeon COPY stepsDockerfile.webapp: switch tonginxinc/nginx-unprivileged:alpineand listen on port 8080Motivation
Both Dockerfiles previously ran as root inside the container. Running as non-root is an industry-standard hardening practice that limits the blast radius if the container process is compromised.
Changes
Dockerfile.server
--chown=node:nodetoCOPY --from=builderdirectives so thenodeuser owns the application filesUSER nodebeforeEXPOSE/CMDDockerfile.webapp
nginx:alpinewithnginxinc/nginx-unprivileged:alpine(official Nginx non-root image)listen 80tolisten 8080(non-root users cannot bind to ports below 1024)EXPOSEfrom 80 to 8080Breaking changes
docker run -pmapping that targets port 80 inside the container must be updated to 8080.Test plan
docker build -f Dockerfile.server .builds successfullydocker build -f Dockerfile.webapp .builds successfullydocker exec <container> whoami