Conversation
… file acquisition
…parameter parsing
erikfrojdh
reviewed
Jun 11, 2025
|
|
||
| using dynamic_shape = std::vector<ssize_t>; | ||
|
|
||
| class ScanParameters { |
Member
There was a problem hiding this comment.
I would put the ScanParameters in it's own file. Makes them easier to find and we can have self contained tests.
erikfrojdh
reviewed
Jun 11, 2025
| * @param type TimingMode | ||
| * @return string representation of the TimingMode | ||
| */ | ||
| template <> std::string ToString(TimingMode arg) { |
Member
There was a problem hiding this comment.
It's probably also time to put ToString/StringTo in a separate file
…tils, scan_parameters
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.