Automatically detect bticino configuration#13
Draft
s0ullight wants to merge 2 commits intoslyoldfox:mainfrom
Draft
Automatically detect bticino configuration#13s0ullight wants to merge 2 commits intoslyoldfox:mainfrom
s0ullight wants to merge 2 commits intoslyoldfox:mainfrom
Conversation
- Add DeviceDetector class to read and parse BTicino mymodules file - Auto-detect locks with device IDs, names, visibility, and button IDs - Generate unique lock names using button IDs to avoid HomeKit conflicts - Add exposeInvisibleLocks flag to control visibility of hidden locks - Remove manual doorUnlock and additionalLocks configuration - Update door-unlock API to work with auto-detected locks
Owner
|
Thank you for your PR, I quickly skimmed through it and have a few questions/remarks:
So for the C300X where I haven't found yet where the configs are stored, there needs to be
If your current code easily supports this, you're free to add it and we'll mark it as breaking, but the default case for C300X must remain and it must be easy to add any additional locks as well in the config.json Extra ❤️ if you also up the documentation with this breaking change :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to automatically detect devices from the BTicino mymodules configuration file.
Currently locks are detected and exposed.
Devices with visible set to 0 are skipped unless configured otherwise.