Update Release workflow

[radcortez]

To use the new release process... I'm unsure if this will work on the first try (probably not :) and will require some adjustments).

This project also releases a Gradle plugin. I did that on the preparation workflow before executing the central one. The files should be updated and tagged:
https://github.com/smallrye/smallrye-graphql/pull/2236/files#diff-ddf2bab74923dcd43f9f8d05e50bb1adc9ee5366a394d151d1f04a54a6079486

There is a separate workflow that executes to do the actual Gradle release after the central one and tag:
https://github.com/smallrye/smallrye-graphql/pull/2236/files#diff-8d232d862a776c1047b335f66544717bd08e86abac7de606a02ffa018563476f

This also seems to require graphviz that most likely we don't have available in the central repo:
https://github.com/smallrye/smallrye-graphql/pull/2236/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L38-L39

[gastaldi]

Can't you set them as environment variables?

[gastaldi]

You need to push the changes somewhere, the prepare-release job below won't execute in the same context as this job

[gastaldi]

I'd recommend having a hook to perform the changes you need in the prepare-release.yml, like in https://github.com/quarkiverse/.github/blob/main/.github/workflows/prepare-release.yml#L118-L124

[radcortez]

Ah, we need to do a git push there.

Then, the job below would just check out the new commit.

[gastaldi]

For git push to work, it depends on the ruleset configured in this repository too (I don't know if the current user is able to bypass the branch restrictions). In any case, I think it would be better if it used the GitHub App token, as in
https://github.com/smallrye/.github/blob/main/.github/workflows/prepare-release.yml#L35-L40

[radcortez]

This also seems to require graphviz that most likely we don't have available in the central repo:
https://github.com/smallrye/smallrye-graphql/pull/2236/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L38-L39

@gastaldi what about this?

[gastaldi]

@radcortez is graphviz required in gradle publishPlugins or when running release:prepare? If the latter, it would be better to change the prepare-release.yml in the smallrye/.github repository to support hooks, as I mentioned in https://github.com/smallrye/smallrye-graphql/pull/2236/files#r1871984725

[gastaldi]

@radcortez see smallrye/.github#5

[radcortez]

@radcortez is graphviz required in gradle publishPlugins or when running release:prepare? If the latter, it would be better to change the prepare-release.yml in the smallrye/.github repository to support hooks, as I mentioned in https://github.com/smallrye/smallrye-graphql/pull/2236/files#r1871984725

I think it is required for javadocs:

smallrye-graphql/pom.xml

Lines 477 to 489 in 95641c9

	<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-javadoc-plugin</artifactId>
	<version>3.5.0</version>
	<configuration>
	<doclet>nl.talsmasoftware.umldoclet.UMLDoclet</doclet>
	<docletArtifact>
	<groupId>nl.talsmasoftware</groupId>
	<artifactId>umldoclet</artifactId>
	<version>2.0.12</version>
	</docletArtifact>
	</configuration>
	</plugin>

[jmartisk]

I am not really sure what that is used for, and I think we may not need it at all - but maybe @phillip-kruger can correct me

[phillip-kruger]

Yea it's used in the Javadoc. See https://javadoc.io/doc/io.smallrye/smallrye-graphql/latest/index.html or https://javadoc.io/doc/io.smallrye/smallrye-graphql/latest/io/smallrye/graphql/execution/package-summary.html as an example

[jmartisk]

Hm, looking at these diagrams, they look a bit crazy, and TBH I don't know if useful. Maybe if it complicates the release too much, we could remove it

[phillip-kruger]

Your call.

[radcortez]

It shouldn't complicate the release, but we do have to add https://github.com/smallrye/smallrye-graphql/pull/2236/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L38-L39 to the action running the release.

I don't see a big issue in it. What do you think @gastaldi?

[gastaldi]

@radcortez when smallrye/.github#5 is merged, you can add a .github/workflows/hooks/pre-prepare-release.sh file to this repository with the commands to install it

[radcortez]

Hm, looking at these diagrams, they look a bit crazy, and TBH I don't know if useful. Maybe if it complicates the release too much, we could remove it

@gastaldi has a way to install the necessary components to support it. Is this something you want to keep so we can prepare the scripts for it?

[jmartisk]

If it's not a big problem, then let's keep it, but I wouldn't mind dropping it either.

[radcortez]

I've tried locally, and it seems to build fine without it. Let me try it without.