Smoke tests - #15
Merged
Merged
Conversation
1. we check that the produced jar contains the the right .so files 2. we spin a minimal vertx server and client and check that their handshake works using openssl
- replace actions tags with commits hash - smoke tests now run in containers using container setup instead of manually executing docker command in 'run'
jponge
reviewed
Aug 12, 2026
|
|
||
| /** | ||
| * Starts a Vert.x HTTPS server and client, both using our native OpenSSL library. | ||
| * With OpenSSL 3.5+ and TLS 1.3, the default key exchange is x25519mlkem768 (post-quantum). |
Member
There was a problem hiding this comment.
Can we have an explicit setting instead of assuming defaults? (which may change)
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter</artifactId> | ||
| <version>5.11.0</version> |
Member
There was a problem hiding this comment.
I'd move all versions to Maven properties, it's easier to handle, even if dependabot is going to manage them fine.
… and its new APIs. Also don't rely on default named groups but specify that we want to use x25519mlkem768
jponge
reviewed
Aug 12, 2026
| .setKeyCertOptions(cert.keyCertOptions()) | ||
| .setOpenSslEngineOptions(new OpenSSLEngineOptions()) | ||
| .setEnabledSecureTransportProtocols(Set.of("TLSv1.3")); | ||
| System.out.println("OpenSSL available: " + OpenSSLEngineOptions.isAvailable()); |
Member
There was a problem hiding this comment.
You should make an assertion on it, not just print it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also replaced actions tags with commits hash