fix(acme): wrap order list response in {"orders": [...]} per RFC 8555#2643
Open
Yanhu007 wants to merge 1 commit intosmallstep:masterfrom
Open
fix(acme): wrap order list response in {"orders": [...]} per RFC 8555#2643Yanhu007 wants to merge 1 commit intosmallstep:masterfrom
Yanhu007 wants to merge 1 commit intosmallstep:masterfrom
Conversation
GetOrdersByAccountID returns a bare JSON array [] instead of the
RFC 8555 §7.1.2.1 required format {"orders": [...]}.
Wrap the response in a struct with an "orders" field. Also guard
against nil slices to ensure empty responses are {"orders":[]}
rather than {"orders":null}.
Fixes smallstep#2629
|
|
github-actions
Bot
added
the
needs triage
Member
|
Hey @Yanhu007, thank you for submitting the PR 🙂 Could you have a look at the CLA? Without approval we can't merge your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2629
Problem
GetOrdersByAccountIDreturns a bare JSON array:RFC 8555 §7.1.2.1 requires:
{"orders": []}Fix
Wrap the response in a struct with an
"orders"field. Guard against nil slices to ensure empty responses are{"orders":[]}not{"orders":null}.Tests updated and passing.