Don't use select *

[ndtretyak]

Name of feature:

Pain or issue this feature alleviates:

All other queries select only required fields, but getAllQry uses SELECT *. I want to add columns to the nosql-created tables and update them via database triggers, but SELECT * prevents this.

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

[hslatman]

Hey @ndtretyak, thank you for opening the PR. Our nosql package has been fairly "stable", in that we haven't done a lot of changes lately. We have an outstanding PR to improve the implementation in #53, which would be a better base for your changes. Have you tried running the CA using that branch yet, and does that support your use case?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Gauss23]

+1 on this one. We added a new column added_at to almost all tables. For revocation list generation this addition breaks the query as the result has 3 columns instead of 2. Only select what you need. It's a really small change. Would be great to see in production soon.

[maraino]

Closed in favor of #93