Deprecate dead config params and wire activity retention#311
Merged
Conversation
- Wire activity retention config (activity_retention_days, activity_max_records, activity_cleanup_interval_min) to runtime by calling SetRetentionConfig() - Add deprecation detection for top_k, enable_tray, and features config fields - Surface deprecated config warnings in `mcpproxy doctor` output - Log deprecation warnings at startup - Mark TopK, EnableTray, Features as deprecated in config struct - Remove dead fields from hot-reload change detection - Remove dead params from docs and OpenAPI schema Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
7006432
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3d3e85da.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://chore-deprecate-dead-config.mcpproxy-docs.pages.dev |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 22524429323 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activity_retention_days,activity_max_records,activity_cleanup_interval_minwere defined in config but never passed toActivityService.SetRetentionConfig()— now they aretop_k(superseded bytools_limit),enable_tray(never read at runtime), andfeatures(all 16 flags unused) are now detected and warned about viamcpproxy doctorand startup logsTest plan
go build ./cmd/mcpproxyand./cmd/mcpproxy-traycompilego test ./internal/config/...— deprecation detection + config tests passgo test ./internal/runtime/...— hot-reload + retention wiring tests passgo test ./internal/management/...— diagnostics tests passgo test ./internal/server/...— server tests passmcpproxy doctorshows deprecated config warnings when dead fields present🤖 Generated with Claude Code