Fix: Zombie Pigmen Creative Agro

[jckitkat]

Description

Fixed issue where zombie pigmen will agro onto a player that is in creative mode.

Previous Behavior

Prior to these changes, zombie pigmen would attempt to attack any player that caused damage, no matter if the offending player was invulnerable or not.

Root Cause

Previously the Entity class had a virtual function called isAttackable that returned true if it was not overwritten by a class extending it. The player class never overwrites this function, and thus, any call to the function simply returns true. The ZombiePig class also never checked this function in its check on whether or not it should agro.

New Behavior

Zombie Pigmen no longer attack a player that is in creative mode.

Fix Implementation

Commit 1: Implemented the isAttackable function in the Player class. The function simply returns the opposite of whether or not the player is invulnerable. Also added this function to the Zombie Pigmen check for whether or not it should agro.

Commit 2: Swapped isAttackable function for isInvulnerable inside Player class and set return value equal to (abilities.invulnerable || hasInvulnerablePrivilege()). Also added same check for the isInvulnerable function to Wolf class to prevent the same issue that zombie pigmen had.

Commit 3: Removed previous change from commit 2 that unnecessarily added check for if the player is invulnerable in the wolf agro checks

Related Issues

• Fixes [Bug] zombie pigmans get mad at you in creative #1095

[codeHusky]

This function seems redundant, just use isInvulnerable please