Fix mouse being pulled to the bottom right#1156
Merged
codeHusky merged 1 commit intosmartcmd:mainfrom Mar 12, 2026
Merged
Conversation
Signed-off-by: Ayush Thoren <ayushthoren@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a big with imprecisions pushing the mouse position in a certain direction.
Changes
Previous Behavior
Previously, mouse movements were pulled slightly to the bottom right. This could be demonstrated by moving the mouse in circles, which caused the cursor to gradually drift to the bottom right instead of staying centered around the same area.
Root Cause
Pointer snapping logic forced odd coordinates to the next even value (
+ x % 2or +y % 2), which introduced a bias in the positive x/y direction over time.New Behavior
Cursor movement is unbiased. Circular mouse motion no longer accumulates drift.
Fix Implementation
Updated positioning logic in
IUIScene_AbstractContainerMenu::onMouseTick():vPointerPos.x = floor(vPointerPos.x + 0.5f)vPointerPos.y = floor(vPointerPos.y + 0.5f)AI Use Disclosure
No AI was used to solve this issue.
Related Issues