Added 16x16 region file support#1167
Closed
MarvelcoCode wants to merge 3 commits intosmartcmd:mainfrom
Closed
Conversation
Contributor
Author
|
dont merge i discovered a bug |
Contributor
Author
|
i will open another pr that is better |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Region files now use 16×16 chunk regions for new worlds while preserving 32×32 for existing saves.
Changes
Previous Behavior
All worlds used 32×32 chunk region files, which broke saved DLC's
Root Cause
No distinction was made between new and existing worlds when choosing the region file format.
New Behavior
New worlds use 16×16 region files, Old worlds automatically fall back to 32×32 if those files are already present. (this also alows us to use newer tut worlds like tu19 tu20 etc and porting worlds from newer versions)
Fix Implementation
In _getRegionFile, before constructing the 16×16 file path, we check if a 32×32 region file already exists and use it instead.
I tested new worlds, old worlds and DLC's creation, saving and reloading