Skip to content

FIX: Item Floating#1173

Open
MozzarellaRat wants to merge 1 commit intosmartcmd:mainfrom
MozzarellaRat:fix-item-float
Open

FIX: Item Floating#1173
MozzarellaRat wants to merge 1 commit intosmartcmd:mainfrom
MozzarellaRat:fix-item-float

Conversation

@MozzarellaRat
Copy link
Contributor

@MozzarellaRat MozzarellaRat commented Mar 12, 2026

Items now float in water.

Description, Previous Behavior, Changes

Item Entities did not float in water. This PR adds an upwards velocity of 0.005f when in water.

Root Cause

It was not implemented.

New Behavior

Item Entities now float in water

Fix Implementation

int tile = level->getTile(x, y, z);
if (tile == Tile::calmWater_Id) yd += 0.045f;
image

Items now float
@MasterBroNetwork
Copy link

Doesn't this contradict actual LCE behavior? (pre Update Aquatic)
Pretty sure items used to just sink to the bottom of the ocean in older versions of it.

@starseed12345
Copy link

Yeah they used to sink i wouldn't want this added for now

@MozzarellaRat
Copy link
Contributor Author

Don't know didn't have lce, just assume it's a bug because why wouldn't items float.

@User-673
Copy link

Doesn't this contradict actual LCE behavior? (pre Update Aquatic) Pretty sure items used to just sink to the bottom of the ocean in older versions of it.

Moreover, it was before the release of update 1.13 in the java version of Minecraft.

@MozzarellaRat
Copy link
Contributor Author

I'm still a little unsure if this is a bug or not, I'll have to research it myself and we'll see!

@starseed12345
Copy link

It is not a bug. Old java version items also didn't float up

@MozzarellaRat
Copy link
Contributor Author

MozzarellaRat commented Mar 12, 2026

Can't use that according to guidelines though, sorry, I'll just research it myself!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants