Switch nightly build archive from zip to 7z (LZMA2)#1181
Closed
MCbabel wants to merge 1 commit intosmartcmd:mainfrom
Closed
Switch nightly build archive from zip to 7z (LZMA2)#1181MCbabel wants to merge 1 commit intosmartcmd:mainfrom
MCbabel wants to merge 1 commit intosmartcmd:mainfrom
Conversation
Collaborator
|
There are better ways to get our file size down 100mb than this atm, and I don’t really personally like the 7zip archive format very much if I’m being honest. We’ll be sticking with .zip for now, but higher compression levels or other zip-compatible compression methods that aren’t super obscure would be fine in a future PR. Either way, I’d focus on eliminating unused files from the repo rather than dealing with this this way |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches the nightly build archive from
.zipto.7z(LZMA2). The resulting download is about 14% smaller (732 MB vs 851 MB), which helps people with slow internet since the nightly updates frequently. Windows can extract.7znatively now so no extra tools needed.Changes
Previous Behavior
The nightly workflow compressed the release build into a
.zipfile using 7-Zip's default zip mode. Output size was around 851 MB.Root Cause
Zip's deflate compression isn't great for this kind of data. 7z with LZMA2 compresses significantly better with no real downside - Windows supports it out of the box and extraction is actually faster.
New Behavior
The nightly release now uploads
LCEWindows64.7zinstead ofLCEWindows64.zip. The archive is ~732 MB (down from ~851 MB). The release body text references the new filename.Fix Implementation
Changed one line in
.github/workflows/nightly.yml:7z a -r -t7z -m0=lzma2 -mx=7 LCEWindows64.7zinstead of7z a -r LCEWindows64.zip.7zLCEWindows64.ziptoLCEWindows64.7zTested by running the workflow manually on a branch - the
.7zarchive was produced correctly and extracts fine.