Fixed Typo of EchantmentTableParticle in multiple instances.#1187
Open
ashthescholar wants to merge 5 commits intosmartcmd:mainfrom
Open
Fixed Typo of EchantmentTableParticle in multiple instances.#1187ashthescholar wants to merge 5 commits intosmartcmd:mainfrom
ashthescholar wants to merge 5 commits intosmartcmd:mainfrom
Conversation
Both filename and contents were changed to remove the misspelling.
Also changed file contents
Changed one line to mirror changes done to fix typos in previous commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed inconsistent spelling of the Enchantment Table Particles in the
Minecraft.clientThis PR fixes it to be more inline with the rest of the files.
Changes
Files
EchantmentTableParticle.h,EchantmentTableParticle.cppwere changed to be renamed toEnchantmentTableParticle.handEnchantmentTableParticle.cpprespectively.References to EchantmentTableParticle have been changed to the correct spelling.
In total, 14 references were corrected.
Previous Behavior
There is no real behaviour change, its just a typo correction.
Root Cause
The person at 4J Studios who made this particle accidentally typed it wrong on multiple occasions (14).
New Behavior
The code does not visibly change after this change at all.
Fix Implementation
I renamed the files related along with changing references to said files.
AI Use Disclosure
NO AI was used in the making of this PR or Fork.