Skip to content

fix: run-e2e-tests quarantine behaviour #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
erikburt wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: run-e2e-tests quarantine behaviour #1449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/run-e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,7 @@ jobs:
TEST_CONFIG_OVERRIDE_PATH: ${{ matrix.tests.test_config_override_path ||
inputs.test_config_override_path }}
TEST_ID: ${{ matrix.tests.id_sanitized || matrix.tests.id }}
QUARANTINE: ${{ inputs.quarantine }}
steps:
- name: Enable S3 Cache for Self-Hosted Runners
# these env vars are set (and exposed) when it is a self-hosted runner with extras=s3-cache
Expand Down Expand Up @@ -840,7 +841,8 @@ jobs:
id: run_tests
timeout-minutes: ${{ matrix.tests.timeout_minutes || inputs.test-timeout-minutes }}
uses: smartcontractkit/.github/actions/ctf-run-tests@ctf-run-tests/0.11.0
continue-on-error: ${{ inputs.quarantine == 'true' }} # auto-quarantine will handle result
# jankiness because: github.com/actions/runner/issues/1492 + github.com/actions/runner/issues/2418
continue-on-error: ${{ fromJSON(env.QUARANTINE) }}
env:
DETACH_RUNNER: true
RUN_QUARANTINED_TESTS: "true" # always run quarantined tests in CI
Expand Down Expand Up @@ -1074,6 +1076,7 @@ jobs:
TEST_CONFIG_OVERRIDE_PATH: ${{ matrix.tests.test_config_override_path ||
inputs.test_config_override_path }}
TEST_ID: ${{ matrix.tests.id_sanitized || matrix.tests.id }}
QUARANTINE: ${{ inputs.quarantine }}
steps:
- name: Enable S3 Cache for Self-Hosted Runners
# these env vars are set (and exposed) when it is a self-hosted runner with extras=s3-cache
Expand Down Expand Up @@ -1151,7 +1154,8 @@ jobs:
id: run_tests
timeout-minutes: ${{ matrix.tests.timeout_minutes || inputs.test-timeout-minutes }}
uses: smartcontractkit/.github/actions/ctf-run-tests@ctf-run-tests/0.11.0
continue-on-error: ${{ inputs.quarantine == 'true' }} # auto-quarantine will handle result
# jankiness because: github.com/actions/runner/issues/1492 + github.com/actions/runner/issues/2418
continue-on-error: ${{ fromJSON(env.QUARANTINE) }}
env:
DETACH_RUNNER: true
RUN_QUARANTINED_TESTS: "true" # always run quarantined tests in CI
Expand Down
Loading