Merged
Conversation
Contributor
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
silaslenihan
approved these changes
Mar 10, 2026
friedemannf
approved these changes
Mar 10, 2026
Fletch153
reviewed
Mar 10, 2026
|
|
||
| // TODO: Config input is not validated for sanity | ||
| func New(lgr logger.Logger, keystore loop.Keystore, config Config, getClient func() (aptos.AptosRpcClient, error)) (*AptosTxm, error) { | ||
| func New(lgr logger.Logger, keystore loop.Keystore, config Config, getClient func() (aptos.AptosRpcClient, error), chainID string) (*AptosTxm, error) { |
Contributor
There was a problem hiding this comment.
ChainID is available in the client
| "github.com/smartcontractkit/chainlink-common/pkg/metrics" | ||
| ) | ||
|
|
||
| var ( |
Contributor
There was a problem hiding this comment.
Is it worth adding tags? so when we submit the same metric from different branch in the code such as on failure, it might be useful to identify the failure
Contributor
Author
There was a problem hiding this comment.
Fletch153
reviewed
Mar 10, 2026
| a.metrics.IncrementFinalizedTxs(ctx) | ||
| } else { | ||
| ctxLogger.Debugw("tx is still unconfirmed", "hash", hash, "chainTx", chainTx) | ||
| totalPending++ |
Contributor
There was a problem hiding this comment.
If we can't store or retry then we have an overcount
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.