[DX-3066] set CL image env var used by simple nodeset#2457
Conversation
|
👋 Tofel, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Pull request overview
Updates the compat backward CLI workflow to better support simple nodesets by exporting the Chainlink image override via CTF_CHAINLINK_IMAGE, and adds a flag to optionally skip pulling Docker images during upgrade iterations.
Changes:
- Set
CTF_CHAINLINK_IMAGE(in addition toCHAINLINK_IMAGE) before running the compat backward sequence. - Add
--skip-pullflag to bypassdocker pullduring node upgrade steps. - Add a framework changeset entry documenting the new env var behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
framework/cmd/main.go |
Adds --skip-pull, sets CTF_CHAINLINK_IMAGE, and conditionally skips docker pull during upgrades. |
framework/.changeset/v0.15.1.md |
Documents the addition of CTF_CHAINLINK_IMAGE in the compat command behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if buildcmd == "" || envcmd == "" || testcmd == "" { | ||
| framework.L.Info().Msg("No envcmd or testcmd provided, skipping") | ||
| framework.L.Info().Msg("No envcmd or testcmd or buildcmd provided, skipping") | ||
| return nil |
There was a problem hiding this comment.
The log message is misleading: the condition triggers when any of buildcmd/envcmd/testcmd is empty, but the message reads as if none were provided. Consider wording that indicates all three are required (or specify which one is missing).
Below is a summarization created by an LLM (gpt-4-0125-preview). Be mindful of hallucinations and verify accuracy.
Why
The changes introduce functionalities aimed at improving usability and flexibility. Specifically, they allow for skipping the docker pull step during testing, which is useful for working with locally built images. Additionally, setting the
CTF_CHAINLINK_IMAGEenvironment variable ensures that both the development environment and simple node setups use the specified Chainlink node image.What
CTF_CHAINLINK_IMAGEin the compat command. This documents the update for release.skip-pullflag to thecompat backwardcommand to skip docker pull steps. This is particularly useful for local testing with locally built images.CTF_CHAINLINK_IMAGEenvironment variable alongsideCHAINLINK_IMAGEduring the compatibility testing command. This ensures the specified Chainlink image is used across different setups.buildcmdin the list of commands that if not provided, will result in skipping certain operations. This clarifies the actions taken when specific commands are not specified.