Modularise EVM chain family in simulate package#364
Closed
Conversation
Fletch153
force-pushed
the
modulise-evm/serene-ibis
branch
2 times, most recently
from
55d42cb to
9bb7707
Compare
Extract EVM-specific simulation code into a chainfamily/evm/ subpackage with an adapter pattern. Introduce a chainfamily.Registry for pluggable chain families instead of hardcoded EVM logic. Simplify simulate.go by removing inline EVM client setup, RPC health checks, and chain-specific flag handling. Includes simulation limits enforcement via limitedEVMChain wrapper in the adapter, and proper service lifecycle management to avoid double-close of chain runtimes.
Fletch153
force-pushed
the
modulise-evm/serene-ibis
branch
from
9bb7707 to
101e247
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chainfamily/evm/subpackage with an adapter patternchainfamily.Registryto support pluggable chain families instead of hardcoded EVM logicsimulate.goby removing inline EVM client setup, RPC health checks, and chain-specific flag handlingsupported_chains.goTest plan
go build ./...passesgo test ./cmd/workflow/simulate/...passes🤖 Generated with Claude Code