Open
Conversation
…martcontractkit/cre-cli into add-deployment-registry-selector
timothyF95
commented
Apr 14, 2026
| @@ -1,4 +1,4 @@ | |||
| package testutil | |||
| package testsettings | |||
Contributor
Author
There was a problem hiding this comment.
This was moved to avoid an import cycle
j-nowak
reviewed
Apr 14, 2026
| // or from a tenant context registry entry selected via deployment-registry. | ||
| type ResolvedRegistry struct { | ||
| ID string | ||
| Type string // "on-chain" or "off-chain" |
Contributor
There was a problem hiding this comment.
Maybe we could extract the type as cosnts/enums?
| ExplorerURL: envSet.WorkflowRegistryChainExplorerURL, | ||
| } | ||
|
|
||
| if reg.Address != nil { |
Contributor
There was a problem hiding this comment.
Does it make sense to resolve a registry without an address?
| // ResolvedRegistry holds the fully resolved registry configuration for a | ||
| // workflow command. It is built from either the static EnvironmentSet defaults | ||
| // or from a tenant context registry entry selected via deployment-registry. | ||
| type ResolvedRegistry struct { |
Contributor
There was a problem hiding this comment.
Have you considered how the code would look like if we had 2 different types representing onchain/offchain regsitry? I'm not the biggest fan, where we have a bag of fields unrelated for a given object type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional deployment-registry field to user-workflow settings that lets workflow commands resolve registry configuration dynamically from context.yaml instead of using hardcoded environments.yaml defaults. When omitted, behaviour is unchanged (backward compatible). Off-chain registries are gated in production and rejected by on-chain-only commands (deploy, pause, activate, delete) with a clear error until off-chain routing is implemented.
Changes:
Example workflow.yaml
Precedence hierarchy