This repository was archived by the owner on Sep 20, 2023. It is now read-only.
Updating Agoric's external initiator for Chainlink V2 Jobs#167
Open
jacquesvcritien wants to merge 3 commits intosmartcontractkit:masterfrom
Open
Updating Agoric's external initiator for Chainlink V2 Jobs#167jacquesvcritien wants to merge 3 commits intosmartcontractkit:masterfrom
jacquesvcritien wants to merge 3 commits intosmartcontractkit:masterfrom
Conversation
Removing the use of the relation because the agoric_subscriptions table is empty and not being used. This is causing issues when restarting the initiator and it tries to load records.
Updated path in sendJobrunTrigger() to /v2/jobs/<id>/runs to match Chainlink V2 Jobs
michaelfig
approved these changes
May 5, 2022
Contributor
michaelfig
left a comment
michaelfig
left a comment
There was a problem hiding this comment.
LGTM! Thanks @jacquesvcritien.
@aalu1418 would you please review or delegate to somebody else? This change is critical for Chainlink v1.1 support, and I'd love to see it as part of the published Docker image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agoric_subscriptionsbecause it is not being used