Use class name provided by association AND support self-referential counts#2
Open
rylwin wants to merge 2 commits into
Open
Use class name provided by association AND support self-referential counts#2rylwin wants to merge 2 commits into
rylwin wants to merge 2 commits into
Conversation
A user may specifiy a class_name on the association. We should respect this setting otherwise we may try to constantize a non-existent class.
Owner
|
Thanks for these changes. Would you mind documenting the new features in the README? |
ghost
assigned
Contributor
|
@rylwin 👍 nice. Can this get merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user may specifiy a class_name on the association. We should respect
this setting otherwise we may try to constantize a non-existent class.
This PR contains a second commit that enables self-referential counts (e.g., parent/child relationship w/in a class). This is done by using a unique table alias name, which is just the original table name with a incrementing number appended.
Unfortunately, I couldn't submit this second commit w/o the first one, since it relies on some code from the first commit. Sorry about that.