Fix simple bindings added to url causing "No URL set" / "out of memory" errors with big insert queries#240
Open
sniek-ie wants to merge 2 commits intosmi2:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Detect typed parameter placeholders (
{name:Type}) against the original SQL (before degenerations),so JSON data injected during degenerations does not erroneously trigger URL
param_*.Why
When JSON contains strings like "{foo:bar}", the current regex runs on the mutated SQL and
thinks we use typed placeholders, causing all simple bindings (:non-typed-binding) to be appended to the URL. With large INSERT batches
this creates extremely long URLs (e.g. >10 MB) and leads to cURL errors like "No URL set!" or "Out of memory".
How
originalSQLtoQueryand runisUseInUrlBindingsParams()against it.Backward compatibility
Tests