Fix: Handle null content_type in hasErrorClickhouse()#243
Open
nzsakib wants to merge 1 commit intosmi2:masterfrom
Open
Fix: Handle null content_type in hasErrorClickhouse()#243nzsakib wants to merge 1 commit intosmi2:masterfrom
nzsakib wants to merge 1 commit intosmi2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
We were flooded with lot of TypeError when we upgraded to
smi2/phpClickHouseversion 1.6.0This is the error we found in our log:
This null case should be handled properly as
$this->response()->content_type()Curl can return null on content typeSummary
content_typeis null in thehasErrorClickhouse()method$contentTypeparameter type fromstringto?stringto accept null valuesstripos()to prevent type errorsChanges
Statement.php:155to accept nullable content type parameter