fix(ci): drop bundle and verify-bundled steps#3
Merged
Conversation
`redocly bundle specs/v3/*.yaml -o bundled/openapi-v3.yaml` treats the output path as a directory when given multiple input files, producing one bundled file per input (e.g. `bundled/openapi-v3.yaml/v3-token.yaml`). Spectral then fails to find `bundled/openapi-v3.yaml` as a single file: No files found to lint The bundle was originally wired up assuming one combined API spec, but `specs/v3/` contains multiple independent specs (one per API) that can't sensibly be merged into a single document. The Lint step already validates each spec individually, so the bundle and verify-bundled steps add no value here. Drop both steps. If a published bundle is needed later it can be a separate publish workflow. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
There was a problem hiding this comment.
Pull request overview
This PR updates the CI validate workflow to stop attempting to bundle multiple independent OpenAPI v3 specs into a single file, eliminating a failing “Verify bundled spec” lint step.
Changes:
- Remove the Redocly
bundlestep from the validate workflow. - Remove the “Verify bundled spec is valid” Spectral lint step that expected a single bundled output.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -23,9 +23,3 @@ jobs: | |||
|
|
|||
| - name: Lint OpenAPI specs with Spectral | |||
| run: npx --yes @stoplight/spectral-cli@^6.14.0 lint specs/v3/*.yaml --fail-severity error | |||
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
After #2 fixed the lockfile issue, the validate workflow now fails on the
Verify bundled spec is validstep:Why:
redocly bundle specs/v3/*.yaml -o bundled/openapi-v3.yamltreats-oas a directory when there are multiple input files, producing one bundled file per input (bundled/openapi-v3.yaml/v3-token.yaml, etc.). Spectral then can't findbundled/openapi-v3.yamlas a single file.The bundle was wired up assuming one combined API spec, but
specs/v3/contains multiple independent specs (one per API) that can't sensibly merge into a single document. The Lint step already validates each spec individually, so the bundle/verify-bundled steps add no value.Drop both. If a published combined artifact is needed later it should live in a separate publish workflow.
Test plan
PR Type
Bug fix
Description
Remove bundle and verify-bundled CI steps
Fix validate workflow failure from multi-file bundling issue
Diagram Walkthrough
File Walkthrough
validate.yml
Remove bundle and verify-bundled CI steps.github/workflows/validate.yml
redocly bundlethe bundled output