Add SAFETY comments and notes for unsafe blocks#79
Open
cblichmann wants to merge 1 commit intosmol-rs:masterfrom
Open
Add SAFETY comments and notes for unsafe blocks#79cblichmann wants to merge 1 commit intosmol-rs:masterfrom
unsafe blocks#79cblichmann wants to merge 1 commit intosmol-rs:masterfrom
Conversation
notgull
requested changes
Aug 22, 2024
Member
notgull
left a comment
There was a problem hiding this comment.
Thanks! I know this was a lot of effort.
Some of the comments have weird word wrap. Could you make sure your new comments respect a common character limit across all files?
Author
All comments should be < 100 chars per line. The Any other preference? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change add SAFETY commands and note for
unsafeblocks that came up during an internal "unsafe review".Adding such comments should make the code easier to reason about and it seems beneficial to retain the result of our internal review.