Require non-closure schedule functions#90
Draft
james7132 wants to merge 7 commits intosmol-rs:masterfrom
Draft
Conversation
```
warning: unnecessary parentheses around type
--> examples/with-metadata.rs:77:11
|
77 | ) -> impl (FnOnce(&'a DurationMetadata) -> MeasureRuntime<'a, F>) {
| ^ ^
|
= note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
help: remove these parentheses
|
77 - ) -> impl (FnOnce(&'a DurationMetadata) -> MeasureRuntime<'a, F>) {
77 + ) -> impl FnOnce(&'a DurationMetadata) -> MeasureRuntime<'a, F> {
|
```
…o remove-schedule
fogti
reviewed
Jan 21, 2026
| /// This metadata may be provided to the user. | ||
| pub(crate) metadata: M, | ||
|
|
||
| pub(crate) schedule: fn(Runnable<M>, ScheduleInfo), |
Member
There was a problem hiding this comment.
This still uses the generic over M, right? Therefore Header has to keep the M generic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses smol-rs/async-executor#149 at this crates' level. This removes the
Scheduletrait and requires a direct function pointer as a scheduling function. This is a usability regression, but it avoids the extra performance cost on all re-schedules. As an alternative to captured variables, a Task can instead embed the required scheduling information inside it's metadata.This is a major breaking change and will require a major version bump on release.