feat(thumbnail): add hash to generated thumbnail image#1311
Closed
mrwiora wants to merge 3 commits intosmplayer-dev:masterfrom
Closed
feat(thumbnail): add hash to generated thumbnail image#1311mrwiora wants to merge 3 commits intosmplayer-dev:masterfrom
mrwiora wants to merge 3 commits intosmplayer-dev:masterfrom
Conversation
Author
|
Adding a sample output thumbnail image:
|
removing duplicate
mrwiora
commented
Feb 5, 2026
Author
mrwiora
left a comment
mrwiora
left a comment
There was a problem hiding this comment.
cleanup (only once displayed hashsum)
* Initial plan * Fix duplicate checksum in saved thumbnail by hiding hash_label during widget grab Co-authored-by: mrwiora <2744285+mrwiora@users.noreply.github.com> * Remove duplicate hash by eliminating manual overlay and hide/show logic Co-authored-by: mrwiora <2744285+mrwiora@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mrwiora <2744285+mrwiora@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a thumbnail overview of a file is even more useful, if it contains more detailled information about the file.
One of the strongest properties is the hash.
Choosing MD5 as default, as it is the least overhead to calculate - however I am open for change requests to set SHA1 or even SHA256 as default. :)