feat: per-rule task timeout via aws_batch_task_timeout resource#42
Conversation
Support a per-rule aws_batch_task_timeout resource that overrides the global --aws-batch-task-timeout setting. Falls back to the setting when the resource is absent; omits the timeout entirely when neither is set. Coerces the value to an integer and enforces the AWS minimum of 60 seconds, with errors naming the source (resource vs flag). Mirrors the existing batch_queue per-rule pattern.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR adds support for per-rule task timeout overrides in AWS Batch job definitions. Rules can now set ChangesPer-Rule Task Timeout Override Feature
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Adds a per-rule
aws_batch_task_timeoutresource that overrides the workflow-level--aws-batch-task-timeoutsetting, mirroring the existing per-rulebatch_queuepattern.Depends on #41 (conditional task-timeout), now merged. Documented under a new "Task Timeout" section in
docs/further.md.Testing
New
TestPerRuleTaskTimeoutcovers precedence, resource-only, fallback, both-absent,< 60, non-numeric, and the exact-60 boundary. Full suite: 61 unit tests pass; black + flake8 clean.Summary by CodeRabbit
Release Notes
New Features
Documentation