test: cover case equivalent to test_singularity_conda in snakemake - #30
test: cover case equivalent to test_singularity_conda in snakemake#30Hocnonsense wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe plugin clears nested container settings before pickling an execution environment. The test suite adds conditional Apptainer coverage. Linux CI installs Apptainer 1.5.3 for testing. ChangesApptainer container execution
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ed9ed03 to
a327370
Compare
|
Hi @johanneskoester, I added In short, the test runs the deployment logic inside the container: Could you please confirm whether this CI failure is related to snakemake#3339, and how you would like to proceed (e.g., fall back to the conda binary, skip this in the snakemake test, or any other workaround)? I've also opened an upstream issue to track it: apptainer/apptainer#3688. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 54-58: Update the Linux CI configuration around the Setup
Apptainer step so TestWithinContainerApptainer does not run in the required job
while its apptainer exec failure remains unresolved. Move the test to a
non-required job or add a targeted skip for the affected condition, without
using broad continue-on-error.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 821ae96e-a3f2-4404-89c5-276261deaf46
📒 Files selected for processing (2)
.github/workflows/ci.ymltests/test_plugin.py
🚧 Files skipped from review as they are similar to previous changes (1)
- tests/test_plugin.py
|
@johanneskoester Update: both the Apptainer hang and the newly exposed failing test is addressed as well:
Waiting for your review! |
Added a test to reproduce what happened in snakemake/snakemake#3339
Summary by CodeRabbit
Bug Fixes
Tests