Skip to content

fix(start_proxy): fail fast on bind error instead of false "Started" #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felipetruman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(start_proxy): fail fast on bind error instead of false "Started" #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/mitmproxy_mcp/core/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,20 @@ async def start(
opts.update(save_stream_file=save_path)
logger.info("flow_dump_enabled", path=save_path)

# pre-check: fail fast if the port is taken. mitmproxy's master.run() dies
# async with SystemExit on bind failure, which would otherwise leave a false
# "Started" + running=True. A synchronous probe bind is deterministic.
import socket
probe = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
try:
probe.bind((host, port))
except OSError as e:
probe.close()
self.master = None
logger.error("proxy_start_failed", host=host, port=port, error=str(e))
return f"Couldn't start the proxy on {host}:{port}: {e}"
probe.close()

self.proxy_task = asyncio.create_task(self.master.run())
self.running = True
logger.info("proxy_started", host=host, port=port)
Expand Down