Fix secondary entrances data extraction#43
Open
marian-m12l wants to merge 1 commit into
Open
Conversation
yeticarus
added a commit
to yeticarus/smw-android
that referenced
this pull request
Feb 10, 2025
yeticarus
added a commit
to yeticarus/smw-android
that referenced
this pull request
Feb 10, 2025
yeticarus
added a commit
to yeticarus/smw-android
that referenced
this pull request
Feb 10, 2025
Cleaner instructions in the readme to encourage using the android port to extract smw-asset.dat (thus interating snesrev/smw#43)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes extraction of the "secondary entrances" data in the python script. Since the support of LM was added, secondary entrances data in range
0x5f800-0x5ffffare ignored, which results in transitioning to a broken "bonus level" whenever mario enters a pipe that should bring him back to the main level.Will this Pull Request break anything?
No.
Suggested Testing Steps
g_runmode = RM_MINE