Skip to content

Remove EXPOSE_HEADER option#97

Open
rpep wants to merge 5 commits into
snok:mainfrom
rpep:remove-expose-header
Open

Remove EXPOSE_HEADER option#97
rpep wants to merge 5 commits into
snok:mainfrom
rpep:remove-expose-header

Conversation

@rpep

@rpep rpep commented Mar 2, 2023

Copy link
Copy Markdown

Match functionality from https://github.com/snok/asgi-correlation-id and remove EXPOSE_HEADER

@sondrelg sondrelg requested a review from JonasKs March 3, 2023 08:42
@JonasKs

JonasKs commented Mar 3, 2023

Copy link
Copy Markdown
Member

Some tests still fail 😊 I'd also love some docs on how to configure CORS😊

@rpep

rpep commented Mar 16, 2023

Copy link
Copy Markdown
Author

@JonasKs think that's alright now and have added the CORS documentation. I've had a look at failing tests and seems to be unrelated - they're currently failing to get past the install stage due to this:
image

Any ideas?

@JonasKs

JonasKs commented Mar 16, 2023

Copy link
Copy Markdown
Member

Thanks for the PR 😊

Huh, weird. I'll have to look, but I'm away for a week or so now.

@rpep

rpep commented Mar 17, 2023

Copy link
Copy Markdown
Author

@JonasKs no worries at all. Give me a ping if you need me to try anything when you’re back :)

@JonasKs

JonasKs commented Feb 7, 2025

Copy link
Copy Markdown
Member

Hi @rpep , I'm sorry for forgetting about this. I've been keeping this library on life-support for a few years now, but I'm happy to accept any contribution and add maintainers.

I'm happy to merge this now, if you guys are (@sondrelg?). Should probably also do a major version bump?

@sondrelg

sondrelg commented Feb 8, 2025

Copy link
Copy Markdown
Member

I think this looks good 👍 Added a few things that'd be nice to implement before a major bump in #86, but some might be outdated and some might not be necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants