Add ECDSA key support for key-pair authentication#2744
Open
jesusmgg wants to merge 13 commits intosnowflakedb:mainfrom
Open
Add ECDSA key support for key-pair authentication#2744jesusmgg wants to merge 13 commits intosnowflakedb:mainfrom
jesusmgg wants to merge 13 commits intosnowflakedb:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Author
|
Heads up: the CLA bot seems broken - returning "Repository was archived so is read-only" when saving signatures. |
Author
|
recheck |
Author
|
Bumping this, the CLA check is still failing. The bot confirmed the signature but the check stays red. @sfc-gh-dszmolka any chance someone could look into this? |
Contributor
|
@jesusmgg please add appropriate change log entry to DESCRIPTION.md |
| """Key pair based authentication.""" | ||
|
|
||
| ALGORITHM = "RS256" | ||
| ALG_RS256 = "RS256" |
Contributor
There was a problem hiding this comment.
Renaming ALGORITHM to ALG_RS256 removes a public class constant, which is a breaking change for any downstream code referencing AuthByKeyPair.ALGORITHM. Consider preserving a backward-compatible alias:
ALGORITHM = ALG_RS256 # deprecated, kept for backward compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3017609: Support ECDSA keys for key-pair authentication #2743
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Adds ECDSA key support (ES256, ES384, ES512) for key-pair authentication.
Snowflake server supports ECDSA keys, but the Python connector only accepted RSA. This change:
EllipticCurvePrivateKeyin addition toRSAPrivateKey(Optional) PR for stored-proc connector:
N/A