Add auto-closing for web browser authentication windows#2775
Open
wenzel-k24 wants to merge 1 commit intosnowflakedb:mainfrom
Open
Add auto-closing for web browser authentication windows#2775wenzel-k24 wants to merge 1 commit intosnowflakedb:mainfrom
wenzel-k24 wants to merge 1 commit intosnowflakedb:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Please add appropriate change log entry to DESCRIPTION.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3168502: Add auto-closing for web browser authentication windows #2774
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
My change updates the HTML “success” response served by the local callback server in the externalbrowser SSO flow. Instead of leaving the page open indefinitely, the response now includes a small JavaScript snippet that attempts to close the browser window automatically a few seconds after the SAML token is received and the connector has progressed past _process_get/_process_post.
After successful authentication, the user sees the same confirmation message, but the window/tab will auto-close after ~5 seconds.
If the browser blocks window.close(), the page still shows clear instructions so the user can close it manually.
No auth logic changes: token handling and request processing remain the same; only the callback success page behaviour is improved, reducing leftover windows and making the flow smoother for repeated logins.