Skip to content

Add auto-closing for web browser authentication windows#2775

Open
wenzel-k24 wants to merge 1 commit intosnowflakedb:mainfrom
wenzel-k24:patch-1
Open

Add auto-closing for web browser authentication windows#2775
wenzel-k24 wants to merge 1 commit intosnowflakedb:mainfrom
wenzel-k24:patch-1

Conversation

@wenzel-k24
Copy link
Copy Markdown

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3168502: Add auto-closing for web browser authentication windows #2774

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.
    My change updates the HTML “success” response served by the local callback server in the externalbrowser SSO flow. Instead of leaving the page open indefinitely, the response now includes a small JavaScript snippet that attempts to close the browser window automatically a few seconds after the SAML token is received and the connector has progressed past _process_get/_process_post.

After successful authentication, the user sees the same confirmation message, but the window/tab will auto-close after ~5 seconds.
If the browser blocks window.close(), the page still shows clear instructions so the user can close it manually.
No auth logic changes: token handling and request processing remain the same; only the callback success page behaviour is improved, reducing leftover windows and making the flow smoother for repeated logins.

  1. (Optional) PR for stored-proc connector:

@wenzel-k24 wenzel-k24 requested a review from a team as a code owner February 26, 2026 16:27
@github-actions
Copy link
Copy Markdown


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@wenzel-k24
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-turbaszek
Copy link
Copy Markdown
Contributor

Please add appropriate change log entry to DESCRIPTION.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-3168502: Add auto-closing for web browser authentication windows

2 participants