NO-SNOW: Extend PR testing matrix to cover all py versions#2825
Open
sfc-gh-turbaszek wants to merge 4 commits intomainfrom
Open
NO-SNOW: Extend PR testing matrix to cover all py versions#2825sfc-gh-turbaszek wants to merge 4 commits intomainfrom
sfc-gh-turbaszek wants to merge 4 commits intomainfrom
Conversation
Contributor
sfc-gh-fpawlowski
left a comment
sfc-gh-fpawlowski
left a comment
There was a problem hiding this comment.
Left few comments
| "cloud-provider": "azure" | ||
| }, | ||
| { | ||
| "os_image_name": "macos-latest", |
Contributor
There was a problem hiding this comment.
So for the newest version we would have only 3.14 aws on the PR branch?
| "cloud-provider": "aws" | ||
| }, | ||
| { | ||
| "os_image_name": "macos-latest", |
Contributor
There was a problem hiding this comment.
Having known the recent issues with 3.9 and 3.10 only on windows - I am not fully convinced that we shouldn't have a bit denser matrix - to at least cover not CSP x OS permutations, but at least such pairs that we have each one run for each version of python? So 6 instead of 9 if im counting correctly?
Versions with test_on_all_os=True are tested on every PR-eligible OS instead of rotating through a single one. Applied to Python 3.14. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: