Use single keyring service name with hashed account keys#2833
Open
sfc-gh-mborins wants to merge 1 commit intomainfrom
Open
Use single keyring service name with hashed account keys#2833sfc-gh-mborins wants to merge 1 commit intomainfrom
sfc-gh-mborins wants to merge 1 commit intomainfrom
Conversation
KeyringTokenCache previously created a separate keychain item per token type, causing multiple macOS password prompts per auth flow. Consolidate all tokens under a single service name (com.snowflake.connector.python) so they share one Keychain ACL entry. The account field now stores a SHA-256 hash of the key to avoid exposing plaintext host/user in the OS credential store. Legacy entries are auto-migrated on first read and the old item is deleted. .... Generated with [Cortex Code](https://docs.snowflake.com/en/user-guide/cortex-code/cortex-code) Co-Authored-By: Cortex Code <noreply@snowflake.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector:
KeyringTokenCache previously created a separate keychain item per token type, causing multiple macOS password prompts per auth flow. Consolidate all tokens under a single service name (com.snowflake.connector.python) so they share one Keychain ACL entry. The account field now stores a SHA-256 hash of the key to avoid exposing plaintext host/user in the OS credential store.
Legacy entries are auto-migrated on first read and the old item is deleted.