[SNOW-3249917] JDBC removal Step 8a: Replicate StageInfo, RemoteStoreFileEncryptionMaterial#1120
Merged
sfc-gh-ggeng merged 1 commit intomasterfrom Mar 28, 2026
Merged
Conversation
3 tasks
sfc-gh-alhuang
approved these changes
Mar 27, 2026
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step7b-replace-file-transfer-agent
branch
from
eed1c75 to
9701b54
Compare
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step8a-stage-info
branch
from
9cdb0d1 to
5cde2f9
Compare
Base automatically changed from
jdbc-removal-step7b-replace-file-transfer-agent
to
master
March 27, 2026 22:54
…FileEncryptionMaterial Verbatim replication of two data classes from JDBC: - StageInfo (229 lines) — stage descriptor with StageType enum, credentials, region, endpoint, presigned URL. @SnowflakeJdbcInternalApi removed. - RemoteStoreFileEncryptionMaterial (46 lines) — encryption key holder. From snowflake-common (decompiled, no public source). Import swaps deferred — StageInfo is tightly coupled with SnowflakeFileTransferMetadataV1 (metadata.getStageInfo() returns JDBC's StageInfo). Both must be swapped together in Step 8b. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sfc-gh-ggeng
force-pushed
the
jdbc-removal-step8a-stage-info
branch
from
5cde2f9 to
19baea1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verbatim replication of two data classes from JDBC:
StageInfo(229 lines) — stage descriptor withStageTypeenum, credentials, region, endpoint, presigned URLRemoteStoreFileEncryptionMaterial(46 lines) — encryption key holder (from snowflake-common, decompiled)Import swaps deferred —
StageInfois tightly coupled withSnowflakeFileTransferMetadataV1(metadata.getStageInfo()returns JDBC'sStageInfo). All types must be swapped together when the upload path is replaced.Stacked on #1119.
Replication Verification Diff Report
StageInfo
JDBC source :
net/snowflake/client/jdbc/cloud/storage/StageInfo.java@ v3.25.1Ingest copy :
src/main/java/net/snowflake/ingest/streaming/internal/fileTransferAgent/StageInfo.javaPermitted differences (mechanical):
@SnowflakeJdbcInternalApiannotations removedUnexpected differences: NONE
RemoteStoreFileEncryptionMaterial
JDBC source :
net/snowflake/client/jdbc/internal/snowflake/common/core/RemoteStoreFileEncryptionMaterial.java(from snowflake-common, no public source)Ingest copy :
src/main/java/net/snowflake/ingest/streaming/internal/fileTransferAgent/RemoteStoreFileEncryptionMaterial.javaPermitted differences (mechanical):
Unexpected differences: NONE (decompiled from JDBC thin jar, verbatim fields/methods)
Test plan
mvn compiler:compilepasses./format.shpasses🤖 Generated with Claude Code