Skip to content

[SNOW-3249917] JDBC removal Step 8c: Swap all imports, replace upload path#1122

Closed
sfc-gh-ggeng wants to merge 0 commit intojdbc-removal-step8b-metadata-v1from
jdbc-removal-step8c-swap-all-imports
Closed

[SNOW-3249917] JDBC removal Step 8c: Swap all imports, replace upload path#1122
sfc-gh-ggeng wants to merge 0 commit intojdbc-removal-step8b-metadata-v1from
jdbc-removal-step8c-swap-all-imports

Conversation

@sfc-gh-ggeng
Copy link
Copy Markdown
Contributor

Summary

The big-bang step: swap all JDBC imports to ingest versions and replace the non-Iceberg upload path.

InternalStage is now completely free of JDBC imports.

Changes

  • InternalStage: swap all 6 JDBC imports to ingest versions, replace getFileTransferMetadatas and uploadWithoutConnection calls, remove parseConfigureResponseMapper Jackson workaround
  • InternalStageManager: swap SnowflakeSQLException
  • SnowflakeFileTransferMetadataWithAge: swap SnowflakeFileTransferMetadataV1
  • All fileTransferAgent files: remove JDBC imports (now same-package)
  • Replicated SnowflakeFileTransferAgent: remove CommandType bridge, use ingest types directly
  • InternalStageTest: update imports, remove JDBC upload verification (PowerMock tests already broken with JDK17)

JDBC imports remaining (for Steps 9a-9c)

  • SFSession in replicated SnowflakeFileTransferAgent (always null)
  • SFException in SnowflakeSQLException (unused constructor)
  • 12 imports in SnowflakeSQLLoggedException (telemetry)
  • 6 imports in TelemetryClient (session path)
  • ObjectMapperFactory and SecretDetector in telemetry classes

Stacked on #1121.

Test plan

  • mvn compiler:compile passes
  • mvn test-compile passes
  • ./format.sh passes
  • FlushServiceTest — 30 tests pass
  • Full IT suite

🤖 Generated with Claude Code

@sfc-gh-ggeng sfc-gh-ggeng requested review from a team as code owners March 24, 2026 22:59
@sfc-gh-ggeng
Copy link
Copy Markdown
Contributor Author

Reverted — cannot swap types in InternalStage while the non-Iceberg upload path still uses JDBC's SnowflakeFileTransferConfig/SnowflakeStorageClient. Need to replicate the full JDBC storage stack first, then swap everything at once.

@sfc-gh-ggeng sfc-gh-ggeng force-pushed the jdbc-removal-step8c-swap-all-imports branch from 2615342 to dafed99 Compare March 26, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant