[SNOW-3249917] JDBC removal Step 8c: Swap all imports, replace upload path#1122
Closed
sfc-gh-ggeng wants to merge 0 commit intojdbc-removal-step8b-metadata-v1from
Closed
[SNOW-3249917] JDBC removal Step 8c: Swap all imports, replace upload path#1122sfc-gh-ggeng wants to merge 0 commit intojdbc-removal-step8b-metadata-v1from
sfc-gh-ggeng wants to merge 0 commit intojdbc-removal-step8b-metadata-v1from
Conversation
Contributor
Author
|
Reverted — cannot swap types in InternalStage while the non-Iceberg upload path still uses JDBC's SnowflakeFileTransferConfig/SnowflakeStorageClient. Need to replicate the full JDBC storage stack first, then swap everything at once. |
2615342 to
dafed99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The big-bang step: swap all JDBC imports to ingest versions and replace the non-Iceberg upload path.
InternalStage is now completely free of JDBC imports.
Changes
getFileTransferMetadatasanduploadWithoutConnectioncalls, removeparseConfigureResponseMapperJackson workaroundSnowflakeSQLExceptionSnowflakeFileTransferMetadataV1JDBC imports remaining (for Steps 9a-9c)
SFSessionin replicatedSnowflakeFileTransferAgent(always null)SFExceptioninSnowflakeSQLException(unused constructor)SnowflakeSQLLoggedException(telemetry)TelemetryClient(session path)ObjectMapperFactoryandSecretDetectorin telemetry classesStacked on #1121.
Test plan
mvn compiler:compilepassesmvn test-compilepasses./format.shpassesFlushServiceTest— 30 tests pass🤖 Generated with Claude Code