[SNOW-3249917] JDBC removal Step 8e: Swap ALL imports to ingest versions#1126
Closed
sfc-gh-ggeng wants to merge 1 commit intojdbc-removal-step8d-storage-clientsfrom
Closed
[SNOW-3249917] JDBC removal Step 8e: Swap ALL imports to ingest versions#1126sfc-gh-ggeng wants to merge 1 commit intojdbc-removal-step8d-storage-clientsfrom
sfc-gh-ggeng wants to merge 1 commit intojdbc-removal-step8d-storage-clientsfrom
Conversation
Now that the full JDBC storage stack is replicated, swap all remaining JDBC imports to ingest versions: InternalStage (now JDBC-free): - SnowflakeFileTransferAgent, SnowflakeFileTransferConfig, SnowflakeFileTransferMetadataV1, SnowflakeSQLException, StageInfo, RemoteStoreFileEncryptionMaterial → ingest versions - OCSPMode → ingest's utils.OCSPMode - Removed parseConfigureResponseMapper (Jackson version workaround no longer needed — both mappers are same version) - Simplified parseFileLocationInfo (no more String roundtrip) InternalStageManager: SnowflakeSQLException → ingest version SnowflakeFileTransferMetadataWithAge: SnowflakeFileTransferMetadataV1 → ingest InternalStageTest: all imports swapped to ingest versions fileTransferAgent package: removed JDBC imports for same-package types (StageInfo, SqlState, ObjectMapperFactory, SnowflakeFileTransferMetadataV1) in ErrorCode, IcebergFileTransferAgent, IcebergStorageClientFactory, IcebergAzureClient, IcebergGCSClient, SnowflakeFileTransferAgent, SnowflakeSQLLoggedException. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Postponed — will do the import swap after all replication steps (9a-9c) are complete, as one final step. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Swap all remaining JDBC imports to ingest versions. InternalStage, InternalStageManager, and SnowflakeFileTransferMetadataWithAge are now completely free of JDBC imports.
Changes
parseConfigureResponseMapper(Jackson version workaround no longer needed), simplifiedparseFileLocationInfoSnowflakeSQLException→ ingest versionSnowflakeFileTransferMetadataV1→ ingest versionJDBC imports remaining (Steps 9a-9c)
Only in replicated classes and telemetry:
SFSession/SFBaseSession/SFSessionPropertyin storage clients andSnowflakeFileTransferAgentSFExceptioninSnowflakeSQLException(unused constructor)SnowflakeSQLLoggedException(telemetry)TelemetryClient(session path)ObjectMapperFactory/SecretDetectorin telemetry classesSnowflakeUtil.assureOnlyUserAccessibleFilePermissions,HttpUtil,RestRequest, etc.)Stacked on #1124.
Test plan
mvn compiler:compilepasses (0 errors)mvn test-compilepasses (0 errors)./format.shpasses🤖 Generated with Claude Code